987496 - Adding Hindi Input Method for B2G

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Swarnava Sengupta (:Swarnava)]

Steps to reproduce:

Tried to type in Hindi (hi, indic language).


Actual results:

No Input Method supporting Hindi was found.


Expected results:

I should have had a keyboard supporting Bangla characters popped up!

Comment 1

[arky [:arky]]

@karunakar Can you please add a patch for review. 

Recent work Hindi Inscript keyboard form Mozilla Hindi L10N work week: 
https://github.com/geekgod/gaia/blob/master/apps/keyboard/js/layouts/hi.js
pull request - https://github.com/mozilla-b2g/gaia/pull/17484

Comment 2

[Axel Hecht [:Pike]]

Attachment: PR for Hindi keyboard

Jan, can you take a look at this?

Comment 3

[Jan Jongboom [:janjongboom] (inactive)]

Comment on attachment 8397669 [details] [review]
PR for Hindi keyboard

Hi, thanks for the initial work. There is an autocorrect file referenced that is not included in the commit. Is there any correction file and does it work with Hindi? Autocorrect was made to work for Latin languages. Also the 'imEngine' is set to Latin, which is not correct I think.

Comment 4

[Joe Cheng [:jcheng] (please needinfo)]

triage: 1.3T+ for tarako release needs. Assign to Luke as he's working on it

Comment 5

[Luke Chang [:lchang] (inactive)]

Attachment: Pull Request 17845

Hi Rudy,
Could you please help to review this patch? Thanks.

Hi James,
Since we're not Hindi language users, could you find someone who is familiar with Hindi language can help us to verify this input method in layouts, characters, and so on? Thanks a lot.

Comment 6

[Luke Chang [:lchang] (inactive)]

Attachment: Screenshot

A screenshot might be helpful to understand this input method.

Comment 7

[arky [:arky]]

(In reply to Luke Chang [:lchang] from comment #6)
> Created attachment 8399932 [details]
> Screenshot
> 
> A screenshot might be helpful to understand this input method.

Looping in Hindi L10N team for feedback

Comment 8

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8399930 [details] [review]
Pull Request 17845

Hi Luke,

Thanks for the patch.
Generally, it looks good to me, but need your help to do some little tweaks,
 1. It seems some character would be too large to fit in the key block, which might need some CSS tweaks to smaller the font.
    You may borrow buri from me to do the test, which could show the fonts correctly.
 2. We need to add this keyboard layout as one of the default layout for Hindi langugage.
https://github.com/mozilla-b2g/gaia/blob/master/build/config/keyboard-layouts.json

Comment 9

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8399932 [details]
Screenshot

Hi Rajesh,

Could you please give some feedback on Luke's work?
Thank you.

Arky,

I think Rajesh is what you intended to consult for feebback, right?
Please correct me if I take anything wrong.
Thank you.

Comment 10

[James Zhang (Spreadtrum)]

(In reply to Luke Chang [:lchang] from comment #5)
> Created attachment 8399930 [details] [review]
> Pull Request 17845
> 
> Hi Rudy,
> Could you please help to review this patch? Thanks.
> 
> Hi James,
> Since we're not Hindi language users, could you find someone who is familiar
> with Hindi language can help us to verify this input method in layouts,
> characters, and so on? Thanks a lot.

Arvin, please ask android owner to review it.

Comment 11

[Guntupalli Karunakar]

Comment on attachment 8399932 [details]
Screenshot

Looks fine as for inscript layout. will try it out and give my feedback in a day.

Comment 12

[Guntupalli Karunakar]

(In reply to Jan Jongboom [:janjongboom] from comment #3)
> Comment on attachment 8397669 [details] [review]
> PR for Hindi keyboard
> 
> Hi, thanks for the initial work. There is an autocorrect file referenced
> that is not included in the commit. Is there any correction file and does it
> work with Hindi? Autocorrect was made to work for Latin languages. Also the
> 'imEngine' is set to Latin, which is not correct I think.

this was actually based on old keyboard so not completed with other files.  Will modify accordingly.

Comment 13

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8399930 [details] [review]
Pull Request 17845

Hi Rudy,

I've addressed those tweaks so set review back. Thank you.

Comment 14

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8399930 [details] [review]
Pull Request 17845

Looks good, r=me.

Luke, thanks for this work.

Comment 15

[helloarvin]

Attachment: reviewresult.png

pls pay attention to the reviewresult.png which shows the main different of hindi kayboard between the android and ffos.

Comment 16

[helloarvin]

Attachment: android-hindi.tar.gz

The attachment android-hindi.tar.gz contains four shortscreen matched the ones of ffos-hindi(Screenshot commited by Luke Chang).

Comment 17

[Luke Chang [:lchang] (inactive)]

Hi Arvin,

Thanks for your feedback. 

The first 6 differences you marked in "reviewresult.png" are most likely caused by font diversity. Could you give me the Unicode of those characters so that I can verify and fix them accordingly?

The "ALT" button is follow our UX design and is consistent with most other input methods in B2G. However, I will address it if "?१२३" and "=\<" are more reasonable to Hindi language users.

Comment 18

[helloarvin]

Hi Luke,

By the way, please check the glyph of the characters combined with the one contains dotted circle(e.g. the character on the screen after we type 6th character and 1st one of the first line),we need to keep all glyphs justly proportioned.

The Unicode of those characters will be provided as soon as i can.

Comment 19

[helloarvin]

Attachment: unicode-reviewresult.png

Hi Luke,

The attachment is the unicode set of characters you need.

Besides, i think the glyph of 0x093c must be modified for the point and the dotted circle almost overlapped together.

Comment 20

[Ashish Namdev]

HI  ,

Hindi layout seems to be ok .
only things to be corrected is

https://bug987496.bugzilla.mozilla.org/attachment.cgi?id=8401225

Comment 21

[Aniket Deshpande]

As per the suggestion of Chandrakant I am suggesting the use of enhanced Inscript keyboard layout
http://malayalam.kerala.gov.in/images/8/80/Qwerty_enhancedinscriptkeyboardlayout.pdf
(This document contains the information on layouts of all languages)

Comment 22

[arky [:arky]]

(In reply to Aniket Deshpande from comment #21)
> As per the suggestion of Chandrakant I am suggesting the use of enhanced
> Inscript keyboard layout

Thanks, Can you file a separate bug to track development of enhanced Inscript keyboard layout.

Comment 23

[Ashish Namdev]

+1  arky ,

 i would also suggest for a differetn bug for other indic languages for better tracking.

Comment 24

[Luke Chang [:lchang] (inactive)]

(In reply to helloarvin from comment #19)
> Hi Luke,
> The attachment is the unicode set of characters you need.
> Besides, i think the glyph of 0x093c must be modified for the point and the
> dotted circle almost overlapped together.

Hi Arvin,

I've confirmed that all the unicode are the same as what you provided. That means it's just a font issue. However, fonts are system-level component which depends on what fonts you pre-install in your devices. The screenshot I attached is based on the default Devanagari font in B2G. You may need to install another Devanagari font by yourself to meet your needs.

Comment 25

[Luke Chang [:lchang] (inactive)]

I've refined my patch and will land it first. I agree with arky on filing another bug for enhanced InScript keyboard layout. Thanks for all your feedback.

Comment 26

[helloarvin]

(In reply to Luke Chang [:lchang] from comment #24)
> (In reply to helloarvin from comment #19)
> > Hi Luke,
> > The attachment is the unicode set of characters you need.
> > Besides, i think the glyph of 0x093c must be modified for the point and the
> > dotted circle almost overlapped together.
> 
> Hi Arvin,
> 
> I've confirmed that all the unicode are the same as what you provided. That
> means it's just a font issue. However, fonts are system-level component
> which depends on what fonts you pre-install in your devices. The screenshot
> I attached is based on the default Devanagari font in B2G. You may need to
> install another Devanagari font by yourself to meet your needs.

Hi Luke,
  According to the discussion of the kick-off meeting yesterday, i have sent the path of all the ttf files via email, please check it, thanks.

Comment 27

[Luke Chang [:lchang] (inactive)]

Hi Arvin,

I've filed a bug above for this font changing issue. Let's track there.

Besides, In attachment 8401225 [details], you marked 3 symbols: "²", "³" and "¢". The "¢" sign is also a font issue so we won't fix it at this bug. The remainder seems need to be replaced but I'm not sure which symbols you prefer to replace with.

Comment 28

[helloarvin]

Hi Luke,

In my opinion, to spell and display exactly of hindi language should be our major concern currently. As for universal symbols，i would like to retain the unique feature of B2G rather than rigidly layout. The reason for "²" and "³" in attachment 8401225 [details] is that i was a little confused with showing the two numbers in the fourth keyboard, and placing the two number into a pure numeric keyboard may be more better.

Comment 29

[Luke Chang [:lchang] (inactive)]

Arvin, thanks for your feedback. The layout will be landed as-is after Noto Sans fonts (bug 993353) are landed.

Comment 30

[James Ho]

any update Luke?

Comment 31

[Luke Chang [:lchang] (inactive)]

Hi James,

The fonts (bug 993353) has been landed yesterday. I'm adjusting the UX accordingly and will land it later today.

Comment 32

[Luke Chang [:lchang] (inactive)]

travis passed:
https://travis-ci.org/mozilla-b2g/gaia/builds/23006607

merged in gaia master:
https://github.com/mozilla-b2g/gaia/commit/1c51a940abbcdc4a396d6a95c130533fb0d6f3fc

Comment 33

[Michael Henretty [:mikehenrty][:mhenretty]]

I'm afraid we are going to need a 1.3t specific fix for this. In bug 920431, we landed some changes to keyboard customizations that this patch relies on. Unfortunately, I don't know enough about keyboard layouts to fix this myself. ni?'ing patch author and Rudy Lu to figure out best way forward.

Guys, do we need to uplift bug 920431 in order to land this, or land a customized fix for 1.3t that doesn't need these changes?

Comment 34

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

As bug991509 comment20, need a separate patch for v1.3t.

Comment 35

[Luke Chang [:lchang] (inactive)]

Attachment: Pull Request 18401 for v1.3t

Rudy, could you help review this again? Thanks!

Comment 36

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8407981 [details] [review]
Pull Request 18401 for v1.3t

r=me.

Luke, thanks.

Comment 37

[Luke Chang [:lchang] (inactive)]

travis passed:
https://travis-ci.org/mozilla-b2g/gaia/builds/23177052

merged in gaia v1.3t branch:
https://github.com/mozilla-b2g/gaia/commit/a8d2d399f2939f4845abaa0df57abab241a2c782

Rudy, Thanks.

Comment 38

[Aniruddha Adhikary [:tuxboy]]

Hindi is missing from v1.4 build, is it necessary for v1.4?

Comment 39

[Delphine Lebédel [:delphine - Use needinfo]]

Just my 2 cents: looking at our internal schedule, it seems we should have Hindi input method for 1.4
And I confirm that we don't have it on 1.4
NI :bajaj so she can weigh in here about this

Comment 40

[Luke Chang [:lchang] (inactive)]

Hi Arvin and Wayne,

Per comment 38 and comment 39, do we need Hindi in v1.4?

Comment 41

[helloarvin]

Hi all,

I think we'd better merge Hindi into v1.4 according to the current requirement on Hindi IME of tarako customers.

Thanks a lot.

Comment 42

[Wayne Chang [:wchang]]

Hi Luke,

Yes please request for 1.4 uplift approval for Hindi and also Tamil.
Please note https://bugzilla.mozilla.org/show_bug.cgi?id=1029934 may need correction/uplift again.

Comment 43

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8399930 [details] [review]
Pull Request 17845

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Feature request (see comment 41)
[User impact] if declined: There would be no Hindi input support on Dolphin
[Testing completed]: Travis Passed
[Risk to taking this patch] (and alternatives if risky): not at all, since Hindi input method is optional at build time
[String changes made]: none

Comment 44

[bhavana bajaj [:bajaj]]

(In reply to Delphine Lebédel [:delphine - please need info] from comment #39)
> Just my 2 cents: looking at our internal schedule, it seems we should have
> Hindi input method for 1.4
> And I confirm that we don't have it on 1.4
> NI :bajaj so she can weigh in here about this

yes, a+ed the patch. Please make sure to verify on 1.4 once this lands.

Comment 45

[Ryan VanderMeulen [:RyanVM]]

v1.4: https://github.com/mozilla-b2g/gaia/commit/5587baf1eab05f5a9b3e5718cff719043b91a5bb

Comment 46

[Luke Chang [:lchang] (inactive)]

Hi Ryan,

Sorry for backing it out. We've already changed the "keyboard" path in v1.4 so we may need to uplift the patch from master branch (attachment 8399930 [details] [review]) instead of v1.3t branch (attachment 8407981 [details] [review]).

I'll take the further job. Thanks.

Comment 47

[Luke Chang [:lchang] (inactive)]

Attachment: Pull Request 22762 for v1.4

This v1.4 patch is blocked by bug 1034210. I'll merge it once bug 1034210 is uplifted.

Comment 48

[Ryan VanderMeulen [:RyanVM]]

OK, in the future, try to check these things ahead of time :)

Comment 49

[Ryan VanderMeulen [:RyanVM]]

Sorry, in a brain-dead moment, I merged this PR. I reverted it after realizing the error. Needinfo? me when bug 1034210 has approval and I can take care of landing both. Sorry for the churn :(

Comment 50

[Ryan VanderMeulen [:RyanVM]]

Luke, it's probably going to be best if you handle the uplifts on this, bug 1034210, and bug 991509. Thanks!

Comment 51

[Luke Chang [:lchang] (inactive)]

No problem. I'll take care of these. Thanks.

Comment 52

[Luke Chang [:lchang] (inactive)]

Uplifted to v1.4 branch.
https://github.com/mozilla-b2g/gaia/commit/e16384ee3faed74edd2027437ab493cef3f3c641